Re: [PATCH] SCSI/qla2xxx: handle sysfs errors

From: Jeff Garzik
Date: Thu Oct 12 2006 - 13:21:01 EST


Andrew Vasquez wrote:
NACK, please don't do this. SYSFS entries, albiet important, aren't
necessarilly critical to a functioning driver. I'd rather the driver
not error out.

As discussed before, the only errors thrown are either ENOMEM or EFAULT, both of which are quite serious.


Here's what I had stewing to address the must_check directives and
qla2xxx:

If you're gonna change it that much, might as well use attribute groups.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/