Re: + clocksource-add-generic-sched_clock.patch added to -mm tree

From: Daniel Walker
Date: Sun Oct 08 2006 - 17:15:53 EST


On Sun, 2006-10-08 at 20:45 +0200, Thomas Gleixner wrote:

> > I'm not moving the kernel/timer.c clocksource user back into
> > kernel/time/clocksource.c . That code completely belongs with the
> > generic time of day changes. The code is directly coupled, and in fact
> > it improves the timekeeping clock switching code to have it that way.
>
> I don't see any reason, why it must be added to timer.c. You can achieve
> the same result with calling the code outside, except that the compiler
> might miss some inline optimization. The switch clock code is not a
> hotpath and so it does not matter whether it is called here or there.

It wouldn't be as clean to integrate the two. The hotpath is improved
(which is what I was referring too above.)

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/