Re: + clocksource-add-generic-sched_clock.patch added to -mm tree

[Thomas Gleixner]

On Sun, 2006-10-08 at 10:26 -0700, Daniel Walker wrote:
> On Sun, 2006-10-08 at 18:54 +0200, Thomas Gleixner wrote:
> > On Sun, 2006-10-08 at 09:27 -0700, Daniel Walker wrote:
> > > On Sun, 2006-10-08 at 18:19 +0200, Thomas Gleixner wrote:
> > > 
> > > > Probably. Anyway, can we just keep the stuff in clocksource.c right
> > > > now ?
> > > 
> > > I suppose I can move the sched_clock stuff.
> > 
> > And keep the code you wanted to move into timer.c too. 
> 
> I'm not moving the kernel/timer.c clocksource user back into
> kernel/time/clocksource.c . That code completely belongs with the
> generic time of day changes. The code is directly coupled, and in fact
> it improves the timekeeping clock switching code to have it that way.

I don't see any reason, why it must be added to timer.c. You can achieve
the same result with calling the code outside, except that the compiler
might miss some inline optimization. The switch clock code is not a
hotpath and so it does not matter whether it is called here or there.

> I'd be happy to create kernel/time/timeofday.c though .

Then please get an agreement with John and Roman, so we can move it now.

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/