Re: [PATCH] Minor coding style fix

[Jan Engelhardt]

>> Kernel generally follow the style
>> 
>> if (func()) {
>> /* failed case */
>> } else {
>> /* success */
>> }

Here's my: NAK.
(At best it should be if(foo != 0) rather than if(foo), but that's just me.)

> I really liked the old code better. If in the future
> init_srcu_struct() is changed to also return >0 for some conditions,
> then that would not previously have triggered BUG(), but after your
> changes it will. The code, as it were, perfectly expressed what it
> wanted to happen - if it returns less than zero it's a BUG().
> I say leave it alone.

I agree here.


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/