Re: [PATCH] ata-piix: kerneldoc-error-on-ata_piixc.patch 2nd try

From: Henne
Date: Mon Sep 25 2006 - 16:37:53 EST


Jeff Garzik schrieb:
> Randy Dunlap wrote:
>> I agree with all of these except #4. Maybe you can reconcile your
>> preference with that in Documentation/SubmittingPatches, which
>> contains:
>>
>> <quote>
>> The canonical patch message body contains the following:
>>
>> - A "from" line specifying the patch author.
>> </quote>
>>
>> A patch submitter should not need to know the patch receiver's
>> personal preferences and vary patches based on those.
>
>
> It's not a personal preference. It's all based on git-applymbox, pretty
> much.
>
> The SubmittingPatches doc should be updated to clarify that a From line
> is not needed in the email body, if it is the same as the From line in
> the RFC822 header.
>
> Jeff
Thanks for pointing my nose on this guys! I'll keep that in mind when writing patches, but that from line
should be discussed by the maintainers.

Greets and thanks,
Henne
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/