Re: [01/12] driver core fixes: make_class_name() retval check

From: Martin Waitz
Date: Thu Sep 14 2006 - 08:02:31 EST


hoi :)

On Wed, Sep 13, 2006 at 06:38:34PM +0200, Cornelia Huck wrote:
> if (class_dev->dev) {
> class_name = make_class_name(class_dev->class->name,
> &class_dev->kobj);
> + if (IS_ERR(class_name)) {
> + error = PTR_ERR(class_name);
> + class_name = NULL;
> + goto out6;
> + }

perhaps it makes sense to return NULL in make_class_name on error,
to have consistent error return values?

--
Martin Waitz

Attachment: signature.asc
Description: Digital signature