Re: [PATCH] AUX_DEVICE_INFO is one byte long, use 'movb'

From: Andi Kleen
Date: Mon Jul 31 2006 - 19:48:53 EST


On Tuesday 01 August 2006 01:47, Diego Calleja wrote:
> Bugzilla #6552 says:
>
> "In arch/i386/boot/setup.S, movw is used instead of movb for PS/2 mouse
> information, although it is unsigned char. This does not harm, because
> the jmp instruction overwritten by movw is used before executing movw,
> and never be used again"
>
> I've no idea if this is a real bug or how it gets fixed, so I'm submitting
> it for review instead of letting it die of boredom in bugzilla. Aditionally
> to i386, I've changed x86-64, which mirrors the same code.
>
> Credits to Yoshinori K. Okuji, who found the problem and suggested a fix.

Queued thanks.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/