Re: [linux-usb-devel] [PATCH] Properly unregister reboot notifier in case of failure in ehci hcd

From: Aleksey Gorelov
Date: Mon Jul 31 2006 - 15:33:58 EST

--- Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, 31 Jul 2006, Aleksey Gorelov wrote:
> > > Why do you need to change the bus glue? Wouldn't it be a lot simpler just
> > > to add ehci_shutdown as a member of ehci_pci_driver, for instance, with
> > > similar changes to ehci_hcd_au1xxx_driver and ehci_hcd_fsl_driver?
> > >
> > > Alan Stern
> >
> > This avoids code duplication for common for both ehci and ohci code
> What code duplication? Doing it the way I suggested doesn't require
> adding any new code at all. You, on the other hand, added several
> routines for bus glue that does virtually nothing.

But you can not use exactly same shutdown function with both pci and platform glue. You need to
convert pci/platform device to hcd anyway, right ? So this will add 2 doing 'virtually nothing'
routines anyway (unless you just want to duplicate the code of shutdown routine for for platform
glue). For ohci, you would need to do the same, hence 2 more routines, 4 total. With bus glue, I
added just 2. Am I missing something here ?

> > (and possibly for uhci, but
> > it currently does not have any notifier/shutdown handler),
> Yes it does. From uhci-hcd.c:

My bad. I did not find notifier, but shutdown handler is indeed there. However, uhci is different
in a way it does not use platform driver.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at