Re: [PATCH] x86 built-in command line (resend)

[Roman Zippel]

Hi,

On Mon, 31 Jul 2006, Matt Mackall wrote:

> +config CMDLINE_BOOL
> +	bool "Default bootloader kernel arguments" if EMBEDDED

You can use a normal depends line here instead of the if.

> +config CMDLINE
> +	string "Initial kernel command string" if EMBEDDED
> +	depends on CMDLINE_BOOL
> +	default "root=/dev/hda1 ro"

This would cause CMDLINE always be set and the simple dependency on 
CMDLINE_BOOL should be enough, so that...

> +#ifdef CONFIG_CMDLINE_BOOL
> +	strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> +#endif

...you only have to test and use CONFIG_CMDLINE here.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/