Re: [PATCH 007 of 11] knfsd: add svc_get

From: Andrew Morton
Date: Mon Jul 31 2006 - 00:06:48 EST


On Mon, 31 Jul 2006 10:42:19 +1000
NeilBrown <neilb@xxxxxxx> wrote:

> /*
> + * We use sv_nrthreads as a reference count. svc_destroy() drops
> + * this refcount, so we need to bump it up around operations that
> + * change the number of threads. Horrible, but there it is.
> + * Should be called with the BKL held.
> + */
> +static inline void svc_get(struct svc_serv *serv)
> +{
> + serv->sv_nrthreads++;
> +}

It's a bit odd for a numa-scalability patch to be increasing our dependency
upon lock_kernel()...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/