Re: [KJ] audit return code handling for kernel_thread [8/11]
From: Stefan Richter
Date: Sat Jul 29 2006 - 12:19:39 EST
nhorman@xxxxxxxxxxxxx wrote:
--- a/drivers/ieee1394/nodemgr.c
+++ b/drivers/ieee1394/nodemgr.c
@@ -426,7 +426,8 @@ static ssize_t fw_set_rescan(struct bus_
* something stupid and spawn this a lot of times, but that's
* root's fault. */
if (state == 1)
- kernel_thread(nodemgr_rescan_bus_thread, NULL, CLONE_KERNEL);
+ if (kernel_thread(nodemgr_rescan_bus_thread, NULL, CLONE_KERNEL) < 0)
+ printk(KERN_WARNING "Could not start 1394 bus rescan thread\n");
return count;
}
Thanks, but (a) we don't need the warnig and (b) we even don't need to
spawn a thread at this point. This call to kernel_thread has been
removed from git-ieee1394 and -mm earlier this month.
http://www.kernel.org/git/?p=linux/kernel/git/bcollins/linux1394-2.6.git;a=commitdiff_plain;h=40fd89cc54a8a67c81b5aa40b22c4f40b39e47b9
http://marc.theaimsgroup.com/?l=linux-mm-commits&m=115189722112717
--
Stefan Richter
-=====-=-==- -=== ===-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/