[patch] ide: eliminate redundant case in start_request()

From: Jason Lunz
Date: Sat Jul 29 2006 - 11:57:16 EST



Collapse two redundant calls to execute_drive_cmd() in start_request().

Signed-off-by: Jason Lunz <lunz@xxxxxxxxxxxx>

---
I can't think of any reason to separate out the two callsites unless
there's some future expansion planned here or something.

drivers/ide/ide-io.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Index: linux-2.6.18-rc2-git6/drivers/ide/ide-io.c
===================================================================
--- linux-2.6.18-rc2-git6.orig/drivers/ide/ide-io.c
+++ linux-2.6.18-rc2-git6/drivers/ide/ide-io.c
@@ -1014,9 +1014,7 @@
if (!drive->special.all) {
ide_driver_t *drv;

- if (rq->flags & (REQ_DRIVE_CMD | REQ_DRIVE_TASK))
- return execute_drive_cmd(drive, rq);
- else if (rq->flags & REQ_DRIVE_TASKFILE)
+ if (rq->flags & (REQ_DRIVE_CMD | REQ_DRIVE_TASK | REQ_DRIVE_TASKFILE))
return execute_drive_cmd(drive, rq);
else if (blk_pm_request(rq)) {
struct request_pm_state *pm = rq->end_io_data;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/