Re: [NFS] [PATCH 000 of 2] knfsd: Don't allow bad file handles to cause extX to go readonly

From: Christoph Hellwig
Date: Fri Jul 28 2006 - 09:31:17 EST

On Fri, Jul 28, 2006 at 10:31:20AM +1000, NeilBrown wrote:
> Currently, and file handle with a bad inode number in it can cause
> ext2 to go to readonly (as it looks like a corrupted filesystem)
> and could allow remote access to ext3 special files like the journal.
> These patches give ext2/3 their own get_dentry method which checks the
> inode number early before other bits of the code can be freaked out by
> it.
> These are revised versions of earlier patches. Rather than exporting
> export_iget, we open code it and simplify it slightly. This avoids
> and extra module dependancy.

This looks much better, agreed. Long-term we should switch ext2/ext2
to use iget_locked so we can propagate errors in finding the inode much

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at