Re: lockdep: results on ARM

From: H. Peter Anvin
Date: Thu Jul 27 2006 - 16:47:05 EST

Arjan van de Ven wrote:
On Thu, 2006-07-27 at 15:24 +0100, Russell King wrote:
+ p->hardirqs_enabled = 1;
p->hardirqs_enabled = 0;

if __ARCH_WANT_INTERRUPTS_ON_CTXSW is set to 1 for arm you can turn this

p->hardirqs_enabled = __ARCH_WANT_INTERRUPTS_ON_CTXSW + 0;

and save the ifdef ;)

#ifdef is actually really evil. It's much cleaner to use #if and make sure everything defines either 0 or 1. Partially because it often makes you not have to add an #if at all, but also because it makes it immediately obvious if some definition was missed.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at