Re: [PATCH] Create IP100A Driver

[Neil Horman]

On Thu, Jul 27, 2006 at 08:54:27AM -0400, John W. Linville wrote:
> On Thu, Jul 27, 2006 at 03:54:25PM -0400, Jesse Huang wrote:
> > From: Jesse Huang <jesse@xxxxxxxxxxxxx>
> > 
> > This is the first version of IP100A Linux Driver.
> 
> One general comment is that your patch is whitespace-damaged,
> undoubtedly mangled by your mailer.  I would suggest that you use
> a text- or curses-based mailer (like mutt or even mail) for sending
> patches, but I'm sure there are graphical mailers that can be trained
> to not be "too smart".
> 
> > +static struct pci_device_id ipf_pci_tbl[] __devinitdata = {
> > +       {0x1186, 0x1002, 0x1186, 0x1002, 0, 0, 0},
> > +       {0x1186, 0x1002, 0x1186, 0x1003, 0, 0, 1},
> > +       {0x1186, 0x1002, 0x1186, 0x1012, 0, 0, 2},
> > +       {0x1186, 0x1002, 0x1186, 0x1040, 0, 0, 3},
> > +       {0x1186, 0x1002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4},
> > +       {0x13F0, 0x0201, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 5},
> > +       {0x13F0, 0x0200, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 6},
> > +       {0,}
> > +};
> 
> This PCI ID table is identical to the one in the sundance driver.
> What advantage does this driver offer over sundance?
> 
> Thanks,
> 
> John

Having read Johns comment, I went back and looked again, and in fact the entire
driver appears to be a copy of the sundance code.  The most significant changes
I can see is that the header includes were moved to ipf.h, and the non-standard
data types (UINT/UCHAR/etc) were added.

Regards
Neil

> -- 
> John W. Linville
> linville@xxxxxxxxxxxxx
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *gpg keyid: 1024D / 0x92A74FA1 - http://pgp.mit.edu
 ***************************************************/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/