Re: [PATCH 1/3] usbhid: Driver for microsoft natural ergonomic keyboard 4000

[Josef Sipek]

On Thu, Jul 27, 2006 at 08:47:58AM +0800, liyu wrote:
> Josef Sipek wrote:
> > +#define map_key(c) \
> > +       do { \
> > +               usage->code = c; \
> > +               usage->type = EV_KEY; \
> > +               set_bit(c,input->keybit); \
> > +       } while (0)
> >
> > I'm not quite sure where usage is coming from. Some magical global variable?
> > Eeek.
> >
> > Josef "Jeff" Sipek.
> >
> >   
> These macroes like map_key() only use in nek4k_setup_usage() and
> ne4k_clear_usage(), so the variable "usage" is coming from their
> parameter.

It is still bad.

> PS: these macroes are modifed from hid-input.c

Well, hid-input.c is wrong. :) Yeah, I just looked at it, and it is horid.

Josef "Jeff" Sipek.

-- 
My public GPG key can be found at
http://www.josefsipek.net/gpg/public-0xC7958FFE.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/