On Wed, 26 Jul 2006, Heiko Carstens wrote:Good catch - I obviously never tested the code for an HWCACHE_ALIGN cache...
We only specify ARCH_KMALLOC_MINALIGN, since that aligns only the kmalloc
caches, but it doesn't disable debugging on other caches that are created
via kmem_cache_create() where an alignment of e.g. 0 is specified.
The point of the first patch is: why should the slab cache be allowed to chose
an aligment that is less than what the caller specified? This does very likely
break things.
Ah, yes, you are absolutely right. We need to respect caller mandated alignment too. How about this?
PekkaSigned-off-by: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
[PATCH] slab: respect architecture and caller mandated alignment
Ensure cache alignment is always at minimum what the architecture or caller mandates even if slab debugging is enabled.
Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>