Re: [NFS] [PATCH] [nfsd] Add lock annotations to e_start and e_stop

[Josh Triplett]

On Wed, 2006-07-26 at 10:19 +0200, Arjan van de Ven wrote:
> On Wed, 2006-07-26 at 09:06 +0100, Christoph Hellwig wrote:
> > On Tue, Jul 25, 2006 at 08:20:24AM -0700, Josh Triplett wrote:
> > > e_start acquires svc_export_cache.hash_lock, and e_stop releases it.  Add lock
> > > annotations to these two functions so that sparse can check callers for lock
> > > pairing, and so that sparse will not complain about these functions since they
> > > intentionally use locks in this manner.
> > > 
> > > Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxx>
> > 
> > The Signed-off-by: line doesn't match the from line of this mail.  Is that
> > any problem or fine in general?
> 
> As far as I can see it's customary for the SOB line to state the
> affiliation of the person, eg the company that wants to own the
> copyright on the code. So I'd expect Josh to use his ibm.com account...

When my internship with IBM ends, the address in the From line stops
working.  I've already run into a number of bounces when sending in
these patches; I don't want to contribute to that problem.  The address
I gave in the Signed-off-by line should always work, as I can change
where it forwards.

- Josh Triplett


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/