Re: [patch] pci/hotplug acpiphp: fix Kconfig for Dock dependencies

From: Keshavamurthy Anil S
Date: Wed Jul 26 2006 - 08:09:59 EST


On Tue, Jul 25, 2006 at 05:13:31PM -0700, Randy.Dunlap wrote:
> On Tue, 25 Jul 2006, Keshavamurthy Anil S wrote:
>
> > On Tue, Jul 25, 2006 at 04:18:54PM -0700, Kristen Carlson Accardi wrote:
> > > drivers/pci/hotplug/Kconfig | 17 ++++++++++++++++-
> > > 1 file changed, 16 insertions(+), 1 deletion(-)
> > Can;t this be done with just one line change?
>
> The first attempted patch was something like:
>
> depends on HOTPLUG_PCI && ACPI_DOCK!=n
>
> but that is not legal kconfig language.
> Did you have something else in mind?

Yup, already mentioned in my first email.
Please see below which is just one line change
and acheives the same as your 17 line change patch.

> > > - depends on ACPI_DOCK && HOTPLUG_PCI
> > depends on (!ACPI_DOCK && ACPI && HOTPLUG_PCI) || (ACPI_DOCK && HOTPLUG_PCI)

-Anil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/