Re: [patch] slab: always follow arch requested alignments

From: Christoph Lameter
Date: Wed Jul 26 2006 - 07:53:45 EST


On Wed, 26 Jul 2006, Pekka J Enberg wrote:

> On Wed, 26 Jul 2006, Pekka J Enberg wrote:
> > Note that this will fix the kmem_cache_init() case too. If
> > ARCH_KMALLOC_MINALIGN is greater than BYTES_PER_WORD, we'll disable
> > debugging for those caches. It's obviously ok to have debugging for
> > kmem_cache_init caches too if ARCH_KMALLOC_MINALIGN is greater than or
> > equal to BYTES_PER_WORD.
>
> Eh, meant "if ARCH_KMALLOC_MINALIGN is less than or equal to
> BYTES_PER_WORD" obviously.

Your patch only deals with ARCH_SLAB_MINALIGN. kmem_cache_create() never
uses ARCH_KMALLOC_MINALIGN only kmem_cache_init() does by passing it to
kmem_cache_create. ARCH_KMALLOC_MINALIGN will still be ignored.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/