Re: [PATCH 5/6] Begin abstraction of sensitive instructions: asm files

[Peter Chubb]

>>>>> "Rusty" == Rusty Russell <rusty@xxxxxxxxxxxxxxx> writes:

Rusty> 	Agreed: certainly eax should be mentioned.  GET_CR0_INTO_EAX?
Rusty> MOV is a bit close to describing how it's happening (which, on
Rusty> paravirt it might not be) so it might lead the reader to
Rusty> unwarranted assumptions.


Aren't these ideal cases to use a tool to convert, rather than adding
manual changes to the source?  The `afterburner' approach works quite
well for this kind of thing.

Peter C
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/