Re: [PATCH 002 of 9] knfsd: knfsd: Remove an unused variable from e_show().
From: Josef Sipek
Date: Tue Jul 25 2006 - 00:09:32 EST
On Tue, Jul 25, 2006 at 11:54:32AM +1000, NeilBrown wrote:
...
> diff .prev/fs/nfsd/export.c ./fs/nfsd/export.c
> --- .prev/fs/nfsd/export.c 2006-07-24 14:33:06.000000000 +1000
> +++ ./fs/nfsd/export.c 2006-07-24 14:33:26.000000000 +1000
> @@ -1178,7 +1178,6 @@ static int e_show(struct seq_file *m, vo
...
> if (p == (void *)1) {
I'm not an NFS expert, but the above makes me want to puke. Isn't there a
cleaner way of doing whatever needs to be done without:
1) hard-coding a constant
2) comparing a variable to an arbitrary pointer
Josef Sipek.
--
If I have trouble installing Linux, something is wrong. Very wrong.
- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/