Re: [PATCH 6/6] cpuid neatening.

[Andi Kleen]

On Mon, Jul 24, 2006 at 04:58:07PM -0700, H. Peter Anvin wrote:
> Rusty Russell wrote:
> >Roll all the cpuid asm into one __cpuid call.  It's a little neater,
> >and also means only one place to patch for paravirtualization.
> 
> The whole point of those is to avoid the unnecessary write to memory and 
> pick it back up again.  This patch reintroduces that ugliness.

Modern gcc should optimize this when it is inlined. If it didn't
most abstracted C++ code would be quite unhappy.

Also as far as I know there is only a single time critical CPUID
in the code and it ignores all output arguments.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/