Re: [v4l-dvb-maintainer] Re: [PATCH] V4L: struct video_devicecorruption

[Trent Piepho]

On Mon, 24 Jul 2006, Mauro Carvalho Chehab wrote:
> Em Dom, 2006-07-23 ās 19:16 -0700, Trent Piepho escreveu:
> > Second, the fix for class_device_create_file() doesn't roll-back properly
> > on failure.  I already posted a patch which does this correctly.  Attached
> > is the patch against the current Hg, go ahead and import it.
> On your hg, there are 4 patches to be applied:
>
> 1) Fix bug where struct video_device was not defined consistently
> This one seems to conflict with some previous changes I did. Please
> remove it from your tree (you need to re-clone it - you may use hg-menu
> to help on this stuff);

My Hg tree was outdated by your patches.  If you look at the time, I made
that fix on Jul 20th, then your comprehensive patch on Jul 23rd
incorporated that part of the fix.

> 3) Handle class_device_create_file in V4L2 drivers
> The patch didn't applied well at current tree.

I know, that's why I attached a version to my email that would.  I have now
re-done my tree to take into account the current code.

> 4) bttv: clean up some pre-2.6.0 class device compat stuff
> the removal of class_device_create_file on compat.h won't break
> compilation against kernel versions 2.4? Yes, I know that current

There was a check in bttv-driver.c that would skip
class_device_create_file() for older kernels (it got the version wrong, but
same idea).  I just moved this check into compat.h so that the bttv code
wouldn't be as cluttered.  My change shouldn't make any difference at all
for bttv under 2.4.  It is just to clean up the code; put compat stuff in
compat.h and not in the drivers when possible.

Other code which called c_d_c_f() will now skip it the same way bttv did
under old kernels.  All the class_device stuff doesn't exist under 2.4, and
there will be a hundred class_device related breakages.  So maybe this
patch fixes one of those hundred breakages.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/