RE: [PATCH 6/6] cpuid neatening.

[Rusty Russell]

> > +static inline void __cpuid(unsigned int *eax, unsigned int *ebx,
> > +			   unsigned int *ecx, unsigned int *edx)
> > +{
> > +	/* ecx is often an input as well as an output. */
> > +	__asm__("cpuid"
> > +		: "=a" (*eax),
> > +		  "=b" (*ebx),
> > +		  "=c" (*ecx),
> > +		  "=d" (*edx)
> > +		: "0" (*eax), "2" (*ecx));
> > +}
> > +
> 
> 	Shouldn't that be:
> 
> __asm__("cpuid"
> : "+a" (*eax),
>   "=b" (*ebx),
>   "+c" (*ecx),
>   "=d" (*edx)
> );

Perhaps?  I copied the existing code...

Rusty.
-- 
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/