Re: [patch] slab: always follow arch requested alignments

From: Christoph Lameter
Date: Sat Jul 22 2006 - 10:53:52 EST


On Sat, 22 Jul 2006, Heiko Carstens wrote:

> In kmem_cache_create(): always check if BYTES_PER_WORD is less than
> ARCH_SLAB_MINALIGN and disable debug options that would set the
> alignment to BYTES_PER_WORD.

Why disable debug options?

> This will make sure that all slab caches will have at least an
> ARCH_SLAB_MINALIGN alignment.

You can specify alignment at cache creation. Why do we need all slabs to
be aligned?

> In addition make sure that a caller mandated align which is greater
> than BYTES_PER_WORD also disables the same debug options.
> This makes sure that ARCH_KMALLOC_MINALIGN also has an effect if
> CONFIG_DEBUG_SLAB is set.

Is there a particular problem you are trying to address?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/