Re: [-mm patch] kernel/lockdep.c: possible cleanups

From: Ingo Molnar
Date: Thu Jun 29 2006 - 09:53:34 EST



* Adrian Bunk <bunk@xxxxxxxxx> wrote:

> On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.17-mm2:
> >...
> > +lockdep-core.patch
> >...
> > Locking validator
> >...
>
> This patch contains the following possible cleanups:
> - make the needlessly global variable lockdep_init_error static
> - make the needlessly global lockdep_print_held_locks() static
> - #if 0 the unused global print_lock_classes()
> (this also implies to #if 0 some static functions)
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

thanks!

Acked-by: Ingo Molnar <mingo@xxxxxxx>

i sent a followup cleanup patch to Andrew that removes those #if 0
sections for real. Let me know if/when you find anything else.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/