Re: [RFC][PATCH 2/2] Twofish cipher x86_64-asm optimized

From: Herbert Xu
Date: Sun May 07 2006 - 08:40:42 EST


On Sun, May 07, 2006 at 12:38:30PM +0200, Andi Kleen wrote:
>
> It would be good if you could run some random input encrypt/decrypt tests
> comparing the C reference version with yours. We have had bad luck
> with assembler functions not quite implementing the same cipher
> in the past.

That's a very good point. The tcrypt module provides both correctness
tests as well as speed tests for twofish. Please run it with your
version versus the existing implementation.

BTW, crypto stuff should cc linux-crypto@xxxxxxxxxxxxxxxx

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/