Re: [RFC][PATCH 2/2] Twofish cipher x86_64-asm optimized

[Andi Kleen]

Joachim Fritschi <jfritschi@xxxxxxxxxx> writes:
> 
> Testing:
> -----------
> The code passed the kernel test module and passed automated tests on a 
> dm-crypt volume reading/writing large files with alternating modules ( c / 
> assembler ) and comparing results. It is also running on my workstation for 
> over a week now.

It would be good if you could run some random input encrypt/decrypt tests 
comparing the C reference version with yours. We have had bad luck 
with assembler functions not quite implementing the same cipher 
in the past.

> 
> Please have a look, try, improve and criticise.

Is it really needed to duplicate all the C code and tables - can't that 
be shared with the portable C code? 

Also don't make it a separate config - it should just be a replacement
on x86-64.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/