Re: [discuss] Re: [PATCH] [6/6] i386: Move CONFIG_DOUBLEFAULT intoarch/i386 where it belongs.

[Randy.Dunlap]

On Tue, 18 Apr 2006 22:12:13 +0200 Andi Kleen wrote:

> On Tuesday 18 April 2006 21:05, Adrian Bunk wrote:
> > On Tue, Apr 18, 2006 at 12:35:22PM +0200, Andi Kleen wrote:
> > > 
> > > Signed-off-by: Andi Kleen <ak@xxxxxxx>
> > >...
> > 
> > NAK.
> >  submitting a patch that is the revert of a patch that went 
> > into Linus' tree just 8 days ago [1], I'd expect at least:
> > - a Cc to the people involved with the patch you are reverting
> > - a note that you are reverting a recent patch in your patch
> >   description
> > - an explanation why you disagree with the patch you are reverting
> 
> The subject was very clear. i386 options belong into arch/i386.

Yes, the timing could have been better.  Whatever.

I agree with Andi that it should be moved back to the ix86 Processor
menu, but not where he moved it to.  My patch is below.

> -Andi (who actually thinks the whole thing was always a bad idea - saving
> a few K but giving up such debugging is a poor trade off)

It does default to Y and can only be changed if EMBEDDED is enabled.
I don't think that it really should be in the Kernel hacking menu.

---

From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

Put DOUBLEFAULT option back in the i386 Processor menu, but
not at the very top of it like it was originally, where it
was out of place in the menu structure.

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
---
 arch/i386/Kconfig |    9 +++++++++
 init/Kconfig      |    9 ---------
 2 files changed, 9 insertions(+), 9 deletions(-)

--- linux-2617-rc1g12.orig/arch/i386/Kconfig
+++ linux-2617-rc1g12/arch/i386/Kconfig
@@ -282,6 +282,15 @@ config X86_VISWS_APIC
 	depends on X86_VISWS
 	default y
 
+config DOUBLEFAULT
+	default y
+	bool "Enable doublefault exception handler" if EMBEDDED
+	help
+          This option allows trapping of rare doublefault exceptions that
+          would otherwise cause a system to silently reboot. Disabling this
+          option saves about 4k and might cause you much additional grey
+          hair.
+
 config X86_MCE
 	bool "Machine Check Exception"
 	depends on !X86_VOYAGER
--- linux-2617-rc1g12.orig/init/Kconfig
+++ linux-2617-rc1g12/init/Kconfig
@@ -374,15 +374,6 @@ config SLAB
 	  SLOB is more space efficient but does not scale well and is
 	  more susceptible to fragmentation.
 
-config DOUBLEFAULT
-	default y
-	bool "Enable doublefault exception handler" if EMBEDDED && X86_32
-	help
-          This option allows trapping of rare doublefault exceptions that
-          would otherwise cause a system to silently reboot. Disabling this
-          option saves about 4k and might cause you much additional grey
-          hair.
-
 endmenu		# General setup
 
 config TINY_SHMEM

---
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/