Re: [patch 5/8] hrtimer remove state field

[Roman Zippel]

Hi,

On Sun, 12 Mar 2006, Thomas Gleixner wrote:

> @@ -633,11 +631,8 @@ static inline void run_hrtimer_queue(str
>  
>  		spin_lock_irq(&base->lock);
>  
> -		/* Another CPU has added back the timer */
> -		if (timer->state != HRTIMER_INACTIVE)
> -			continue;
> -
> -		if (restart != HRTIMER_NORESTART)
> +		if (restart != HRTIMER_NORESTART &&
> +		    !hrtimer_active(timer))
>  			enqueue_hrtimer(timer, base);
>  	}
>  	set_curr_timer(base, NULL);

BTW the active check can be removed again, as it was added for a state 
machine problem, I only didn't want to remove it for 2.6.16.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/