Re: Geode LX HW RNG Support

From: Andrew Morton
Date: Thu Dec 15 2005 - 17:46:23 EST


Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
> Andrew Morton wrote:
> > "Jordan Crouse" <jordan.crouse@xxxxxxx> wrote:
> >
> >>>Should all the Geode additions to hw_random.c be inside __i386__, like VIA?
> >>
> >>I thought that a early version did that and somebody took exception to
> >>it, but I can't find any e-mails to that effect right now. Obviously,
> >>the defines are only useful when you have a Geode CPU (and thus a x86_32),
> >>so if nobody complains, I think that would be fine.
> >
> >
> > Fair enough. Please send an update sometime.
> >
> > We might as well do s/__i386__/X86_32/ throughout that file - bit pointless
> > but it's a little bit more idiomatic.
>
> What about the rng rewrite recently posted? Any opinions on that?

(http://lkml.org/lkml/2005/10/29/145)

Looks sane. It ended up with Deepak deciding to split the various
manufacturer bits apart and then send the patches in my direction. I don't
think that happened?

> I lean towards applying it, long term, but IIRC there were problems that
> prevented immediate merge.

There was some talk about moving functionality to userspace, but it seems a
bit speculative.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/