Re: [PATCH] x86_64 NUMA : Bug correction in populate_memnodemap()
From: Andi Kleen
Date: Wed Dec 07 2005 - 12:46:04 EST
On Wed, Dec 07, 2005 at 04:35:18PM +0100, Eric Dumazet wrote:
> As reported by Keith Mannthey, there are problems in populate_memnodemap()
>
> The bug was that the compute_hash_shift() was returning 31, with incorrect
> initialization of memnodemap[]
>
> To correct the bug, we must use (1UL << shift) instead of (1 << shift) to
> avoid an integer overflow, and we must check that shift < 64 to avoid an
> infinite loop.
Thanks looks good.
I guess we'll need that for 2.6.15.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/