Re: Missing break in timedia serial setup.

From: Dave Jones
Date: Wed Dec 07 2005 - 12:43:42 EST


On Wed, Dec 07, 2005 at 06:05:19PM +0100, Arjan van de Ven wrote:

> might as well add a /* fall through */ comment
> so that this doesn't come up again in the future..

Remove redundant assignment, and mark fallthrough.

Signed-off-by: Dave Jones <davej@xxxxxxxxxx>

--- linux-2.6.14/drivers/serial/8250_pci.c~ 2005-12-07 12:42:58.000000000 -0500
+++ linux-2.6.14/drivers/serial/8250_pci.c 2005-12-07 12:43:08.000000000 -0500
@@ -516,7 +516,7 @@ pci_timedia_setup(struct serial_private
break;
case 3:
offset = board->uart_offset;
- bar = 1;
+ /* FALLTHROUGH */
case 4: /* BAR 2 */
case 5: /* BAR 3 */
case 6: /* BAR 4 */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/