Re: [PATCH] noop-iosched: reimplementation

From: Jens Axboe
Date: Thu Nov 10 2005 - 12:17:34 EST


On Thu, Nov 10 2005, Tejun Heo wrote:
> The original implementation directly used dispatch queue. As new
> generic dispatch queue imposes stricter rules over ioscheds and
> dispatch queue usage, this direct use becomes somewhat problematic.
> This patch reimplements noop-iosched such that it complies to generic
> iosched model better. Request merging with q->last_merge and
> rq->queuelist.prev/next work again now.

Yep this looks like what I had in mind as well, I'll apply it.

> Jens, this one also received several hours of testing which involves a
> lot of request merging, but it might still be a better idea to wait
> for the next release. Oh... Are we still in the merging window for
> 2.6.15? If so, this one can go in, I guess.

I guess we can sneak this one in after the window even, if we
characterize it as a regression fix as compared to 2.6.14 :-)

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/