Re: [PATCH] Driver Core: document struct class_device properly

From: Dmitry Torokhov
Date: Fri Oct 28 2005 - 01:55:24 EST


On Friday 28 October 2005 01:30, Greg KH wrote:
> [PATCH] Driver Core: document struct class_device properly
...

> + * @release: pointer to a release function for this struct class_device. If
> + * set, this will be called instead of the class specific release function.
> + * Only use this if you want to override the default release function, like
> + * when you are nesting class_device structures.
> + * @hotplug: pointer to a hotplug function for this struct class_device. If
> + * set, this will be called instead of the class specific hotplug function.
> + * Only use this if you want to override the default hotplug function, like
> + * when you are nesting class_device structures.

Greg,

Is this solution for nesting class devices considered permanent or is it
a stop-gap measure? I hope it is latter as these 2 new methods allow one
class device walk all over class's intended interface and semantics and
you can no longer rely that objects of the same class have similar
characteristics/attributes and similar behavior. You already had to
abandon using class's default attributes when dealing with nested devices,
I think it is wrong long-term solution.

What about Kay's proposal about moving (as far as userspace concerned)
everything into /sys/devices?

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/