Re: [NUMA , x86_64] Why memnode_shift is chosen with the lowest possible value ?

From: Andi Kleen
Date: Tue Oct 04 2005 - 12:13:43 EST


On Friday 30 September 2005 11:09, Eric Dumazet wrote:
> +ÂÂÂÂÂÂÂwhile (populate_memnodemap(nodes, numnodes, shift + 1) >= 0)
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂshift++;


Why shift+1 here?


>+ if ((end >> shift) >= NODEMAPSIZE)
>+ return 0;

This should be >, not >= shouldn't it?

-Andi

P.S.: Please cc x86-64 patches to discuss@xxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/