Re: [2.6 patch] kill include/linux/platform.h

[Adrian Bunk]

On Mon, Oct 03, 2005 at 02:07:12PM -0700, Tony Luck wrote:
> > The default_idle() prototype should stay inside some header file.
> 
> That would be best, yes.
> 
> > @Patrick:
> > Any suggestion where it should move to?
> 
> Of the include files already included directly by arch/ia64/kernel/setup.c,
> <linux/sched.h> looks the most promising.  There's lots of .*idle.* things
> already in there.
> 
> Looking at existing precedent: ppc64 has a definition of default_idle()
> in <asm/machdep.h>

The question whether linux/ or asm/ is the best place for the definition 
boils down to the question whether it is expected that default_idle() is 
present on all architectures or whether it's an architecture-specific 
implementation detail.

In the first case, I'm surprised that there is no platform independent 
code using it.

In the second case, it seems we can kill the default_idle() functions on 
mips (empty) and parisk.

> i396, cris and um already have gone along the route of adding extern
> definitions for default_idle() to ".c" files ... so cleanup creates more
> opportunities for cleanup (but you are probably very experienced in
> this phenomenom :-)

I stumbled across the question whether include/linux/platform.h is still 
required by cleaning up warnings with the -Wmissing-prototypes compiler 
flag I plan to add to the kernel CFLAGS soon that generates warnings 
for such extern constructs...

> -Tony

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/