Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

From: Grant Coady
Date: Sat Jul 30 2005 - 04:44:15 EST


On Fri, 29 Jul 2005 18:21:05 -0400, Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
>[speaking to the audience] I wouldn't mind if someone did a pass
>through pci_ids.h and removed all the constants that are not being used.
> If constants are not being used, it's IMHO more appropriate to store
>that info in pci.ids.

For:

linux-2.6.13-rc4:
118 pci_ids-defined_elsewhere-files
475 pci_ids-defined_elsewhere-items
7 pci_ids-duplicate-items
2321 pci_ids-list
725 pci_ids-not_used

linux-2.6.13-rc3-mm3:
119 pci_ids-defined_elsewhere-files
475 pci_ids-defined_elsewhere-items
7 pci_ids-duplicate-items
2325 pci_ids-list
723 pci_ids-not_used

Should the 'defined elsewhere' items be brought into the one
pci_ids.h file? Testing will take time. Patch is ~70kB.

Grant.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/