Re: [PATCH 0/23] reboot-fixes

From: Pavel Machek
Date: Thu Jul 28 2005 - 02:46:55 EST


Hi!

> >> > Yes, I think we should do device_suspend(PMSG_FREEZE) in reboot path.
> >>
> >> Considering how many device drivers that are likely broken, I disagree.
> >> Especially since Andrew seems to have trivially found a machine where it
> >> doesn't work.
> >
> > I'm not sure if we want to do that for 2.6.13, but long term, we
> > should just tell drivers to FREEZE instead of inventing reboot
> > notifier lists and similar uglynesses...
>
> Then as part of the patch device_shutdown should disappear. It
> is silly to have two functions that want to achieve the same
> thing.

I always thought that device_shutdown is different phase -- the one
with interrupts disabled...
Pavel
--
teflon -- maybe it is a trademark, but it should not be.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/