Re: [PATCH 0/23] reboot-fixes
From: Eric W. Biederman
Date: Wed Jul 27 2005 - 18:27:18 EST
Pavel Machek <pavel@xxxxxxx> writes:
>> > Yes, I think we should do device_suspend(PMSG_FREEZE) in reboot path.
>> Considering how many device drivers that are likely broken, I disagree.
>> Especially since Andrew seems to have trivially found a machine where it
>> doesn't work.
> I'm not sure if we want to do that for 2.6.13, but long term, we
> should just tell drivers to FREEZE instead of inventing reboot
> notifier lists and similar uglynesses...
Then as part of the patch device_shutdown should disappear. It
is silly to have two functions that want to achieve the same
Right now the device driver model is ugly and over complicated in
that case and it needs to be simplified so driver writers have
a chance of getting it correct.
device_suspend(PMSG_FREEZE) feels more reusable than device_shutdown
so long term it feels right.
But a simple question is why can't you simply use the shutdown
method instead of extending the suspend method in the drivers.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/