Re: [warning: ugly, FYI] battery charging support for sharp sl-5500

[Pavel Machek]

Hi!

> I have similar problems with the corgi battery driver which is probably
> even more of a mess than this. My conclusion is the whole lot needs
> rewriting in a nice fashion before it can be included in mainline. My
> work so far on the corgi code is here:
> 
> http://www.rpsys.net/openzaurus/patches/corgi_power-r24.patch

+void corgikbd_setled_charge(int led_set)
+{
+	if (led_set) 
+		GPSR0 = GPIO_bit(CORGI_GPIO_LED_ORANGE);
+	else
+		GPCR0 = GPIO_bit(CORGI_GPIO_LED_ORANGE);
+}

Ugh... GPSR0 / GPCR0 looks _very_ similar :-(. I thought I am seeing
an error.
								Pavel

-- 
teflon -- maybe it is a trademark, but it should not be.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/