Re: [PATCH 16/23] swpsuspend: Have suspend to disk use factors of sys_reboot

[Pavel Machek]

Hi!

> > The suspend to disk code was a poor copy of the code in
> > sys_reboot now that we have kernel_power_off, kernel_restart
> > and kernel_halt use them instead of poorly duplicating them inline.
> > 
> > Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
..
> This one conflicts in both implementation and intent with the below, from Pavel.  I'll
> drop Pavel's patch.
> 
> 
> From: Pavel Machek <pavel@xxxxxx>
> 
> Do not call device_shutdown with interrupts disabled.  It is wrong and
> produces ugly warnings.

Okay with me.
								Pavel
-- 
teflon -- maybe it is a trademark, but it should not be.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/