Re: [PATCH 2.4.31 1/1] scsi/megaraid2: add 64-bit application support

From: Marcelo Tosatti
Date: Tue Jul 26 2005 - 15:32:55 EST



Hi Seokmann,

On Fri, Jul 15, 2005 at 11:32:08AM -0400, Ju, Seokmann wrote:
> This patch contains accumulated changes over the time.
>
> Description of the changes.
> ### Version 2.10.10.1
> Thu Jan 27 15:59:59 EDT 2005 - Seokmann Ju <sju@xxxxxxxx>
> 1. There was a bug in the 'megadev_ioctl()' function that cause random
> deletion error and has been fixed.
>
> ### Version 2.10.10.0
> Fri Jan 21 15:59:59 EDT 2005 - Seokmann Ju <sju@xxxxxxxx>
> 1. Fixed Tape drive issue : For any Direct CDB command to physical
> device
> including tape, timeout value set by driver was 10 minutes. With
> this
> value, most of command will return within timeout. However, for
> those
> command like ERASE or FORMAT, it takes more than an hour depends on
> capacity of the device and the command could be terminated before it
> completes.
> To address this issue, the 'timeout' field in the DCDB command will
> have NO TIMEOUT (i.e., 4) value as its timeout on DCDB command.
> 2. Added NEC ROMB support : NEC MegaRAID PCI Express ROMB controller


> @@ -83,6 +83,7 @@
> #define INTEL_SUBSYS_VID 0x8086
> #define FSC_SUBSYS_VID 0x1734
> #define ACER_SUBSYS_VID 0x1025
> +#define NEC_SUBSYS_VID 0x1033
>
> #define HBA_SIGNATURE 0x3344
> #define HBA_SIGNATURE_471 0xCCCC
> @@ -143,7 +144,8 @@
> .eh_device_reset_handler = megaraid_reset, \
> .eh_bus_reset_handler = megaraid_reset, \
.eh_host_reset_handler = megaraid_reset, \
> - .highmem_io = 1 \
> + .highmem_io = 1, \
> + .vary_io = 1 \

vary_io has never been part of mainline. How come did you add it
here?

> -#if defined(__x86_64__)
> +#if defined(CONFIG_COMPAT) || defined( __x86_64__) ||

There is no CONFIG_COMPAT on v2.4... thanks James and Christoph
for reviewing.

> defined(IA32_EMULATION)
> +#ifndef __ia64__
> +#define LSI_CONFIG_COMPAT
> +#endif
> +#endif
> +
> +
> +#ifdef LSI_CONFIG_COMPAT
> static int megadev_compat_ioctl(unsigned int, unsigned int, unsigned long,
> struct file *);
> #endif

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/