Re: [PATCH] more signed char cleanups in scripts

From: Paulo Marques
Date: Wed Jun 22 2005 - 06:51:21 EST

J.A. Magallon wrote:
On 06.22, Andrew Morton wrote:
I see no particular problem using uchar in the kallsyms code - I often
prefer it, because you can just look at the code and not have to worry
about nasty sign-extension problems.

Forget the part for kallsyms. After my change, it just coredumps.
The original gcc warnings are below. The problem is using str---
on data that are not strictly strings, but arrays of bytes...
Each symbol struct has a field. 'sym', that stores a 'type'
in sym[0] and a name from sym[1] to the end. A strange hacky mix.

Tell me about it :)

I'll look at the warnings and try to clean them up myself, if that's ok with you, since I'm in the middle of changing that code anyway.

The reason for the unsigned nature of those tokens is that after compression they really do hold "binary data" and not "text", so I wanted to keep that clear by using unsigned chars.

Anyway, thanks for the gcc4.0 output. Since I don't have a gcc4.0 installed yet, I can use it to fix these issues and post a patch ASAP.

Paulo Marques -

It is a mistake to think you can solve any major problems
just with potatoes.
Douglas Adams
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at