Re: [Linux-fbdev-devel] [RFC/PATCH 2.6.12-rc5 1/1] Framebuffer driverfor Arc LCD board

[James Simmons]

> Hi Antonino, Andrew, FBdev folk,
> 
> I added akpm's fixes below, then further cleanup and irq support: 
> - coding style fixes
> - removing unneeded typecasts
> - namespace fixes
> 
> I had used skeletonfb.c to start with and that had fb_get_options.
> I've removed that and the redundant param retrieval from arcfb as 
> per akpm's mention of the redundancy of fb_get_options/*_setup. 
> I also cleaned up some other duplicate code. I've listed the 
> driver as maintained and added myself. I did this diff against
> rc5. Should I be doing it against -mm instead?
> 
> Please let me know if you have any feedback or suggestions.

It looks really good :-) Please apply.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/