Re: [patch 6/9] dlm: clear recovery flags

From: Arjan van de Ven
Date: Thu Jun 02 2005 - 03:27:24 EST


On Thu, 2005-06-02 at 16:03 +0800, David Teigland wrote:
> plain text document attachment (clear-recovery-flags.patch)
> At the start of recovery, all the recovery flags are cleared from the
> previous recovery. Two of them weren't being cleared.
>
> Signed-off-by: David Teigland <teigland@xxxxxxxxxx>
>
> Index: linux/drivers/dlm/member.c
> ===================================================================
> --- linux.orig/drivers/dlm/member.c 2005-06-02 12:28:30.000000000 +0800
> +++ linux/drivers/dlm/member.c 2005-06-02 13:07:46.060566696 +0800
> @@ -276,6 +276,8 @@
> */
>
> dlm_recoverd_suspend(ls);
> + clear_bit(LSFL_LOCKS_VALID, &ls->ls_flags);
> + clear_bit(LSFL_ALL_LOCKS_VALID, &ls->ls_flags);
> clear_bit(LSFL_DIR_VALID, &ls->ls_flags);
> clear_bit(LSFL_ALL_DIR_VALID, &ls->ls_flags);
> clear_bit(LSFL_NODES_VALID, &ls->ls_flags);

btw do these need to be atomic? right now these are atomic ops and thus
very expensive... you might want to switch to nonatomic variants if
that's not needed.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/