Re: [PATCH 2/2] porting lockless mce from x86_64 to i386

[Hugh Dickins]

On Thu, 19 May 2005, Guo Racing wrote:

> Lockless MCE(machine check exception) is ported from
> x86-64 to i386. This patch is for implementation.

You seem to be missing most of the issues people raise:
perhaps your spamfilter is too eager.

Where is Brice Goglin's #include <asm/apic.h> in mce_intel.c?

i386 machine_check_init misses calling mcheck_init in Intel
and Centaur cases, so a lot of the code is largely untested.

You need to avoid the P6 and AMD problems with bank0,
as the replaced code did.

I fear there may be more.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/