Re: 2.6.12-rc4-mm2: proc-pid-smaps.patch broke nommu

[Mauricio Lin]

Hi Adrian,

I guess that the code below you have to include in the
fs/proc/task_nommu.c. But I would like to replicate the error you
found and apply the code below to verify if it is correct. So if you
can explain how you got this error I can test the code below. If you
want to test the code below by yourself, let me know about the result
please.

static int show_smap(struct seq_file *m, void *v)
{
	return 0;
}

struct seq_operations proc_pid_smaps_op = {
	.start	= m_start,
	.next	= m_next,
	.stop	= m_stop,
	.show	= show_smap
};

BR,

Mauricio Lin.

On 5/20/05, Mauricio Lin <mauriciolin@xxxxxxxxx> wrote:
> Hi Adrian,
> 
> How did you get this error? What is your configuration?
> 
> I would like to replicate it.
> 
> BR,
> 
> Mauricio Lin.
> 
> On 5/16/05, Adrian Bunk <bunk@xxxxxxxxx> wrote:
> > It seems proc-pid-smaps.patch is guilty for this nommu breakage in -mm:
> >
> > <--  snip  -->
> >
> > ...
> >   LD      vmlinux
> > fs/built-in.o(.text+0x32b08): In function `smaps_open':
> > /usr/src/ctest/mm/kernel/fs/proc/base.c:560: undefined reference to `_proc_pid_smaps_op'
> > make[1]: *** [vmlinux] Error 1
> >
> > <--  snip  -->
> >
> > cu
> > Adrian
> >
> > --
> >
> >        "Is there not promise of rain?" Ling Tan asked suddenly out
> >         of the darkness. There had been need of rain for many days.
> >        "Only a promise," Lao Er said.
> >                                        Pearl S. Buck - Dragon Seed
> >
> >
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/