Re: [PATCH 2.6.12-rc4] Add EXPORT_SYMBOL for hotplug_path

From: Greg KH
Date: Fri May 20 2005 - 01:27:18 EST


On Fri, May 20, 2005 at 12:18:23AM -0500, Dmitry Torokhov wrote:
> On Friday 20 May 2005 00:18, Greg KH wrote:
> > On Thu, May 19, 2005 at 09:43:23AM -0700, Tom Rini wrote:
> > > If CONFIG_INPUT is set as a module, it will not load as hotplug_path is
> > > not a defined symbol. Trivial fix is to EXPORT_SYMBOL hotplug_path.
> > >
> > > Signed-off-by: Tom Rini <trini@xxxxxxxxxxxxxxxxxxx>
> >
> > Ick, no, I thought we got rid of that usage. no one should be calling
> > hotplug on their own, lots of bad things happen to udevd and HAL if they
> > do.
> >
> > What caused the input code to be added back into the kernel? I'll try
> > to go track that down...
> >
>
> The change never made it into the kernel. And I need to finish proper
> input_dev sysfs conversion...

Ah, ok, thanks. So I'll ACK the EXPORT_SYMBOL_GPL() version of this
patch for now.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/